Conversation
precursor for python3.12
Rob-Johnson
force-pushed
the
u/robj/py312-upgrade
branch
from
296a7da to
383fe25
Compare
| python3.7-dev \ | ||
| python3.7-distutils \ | ||
| python3-pip \ | ||
| libffi-dev \ |
There was a problem hiding this comment.
if only we could ensure that public pypi had wheels for everything - when we could get rid of all the -dev packages :p
| ARG DEBIAN_FRONTEND=noninteractive | ||
| ENV DEBIAN_FRONTEND=${DEBIAN_FRONTEND} |
There was a problem hiding this comment.
imo, we can just hardcode this :p
| "host": MY_IP_ADDRESS, | ||
| "port": 1024, | ||
| "weight": CPUS, | ||
| "weight": 10, |
There was a problem hiding this comment.
if we're not using CPUS anymore, we probably wanna remove it at the top of the file
|
|
||
| echo "installing hacheck" | ||
| GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" git clone git@github.yelpcorp.com:packages/hacheck && cd /hacheck && python3.7 -m pip install . && cp /usr/local/bin/ha* /usr/bin/ | ||
| GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" git clone --depth=1 git@github.yelpcorp.com:packages/hacheck /hacheck |
There was a problem hiding this comment.
heh, i guess we haven't been expecting folks to run these itests outside of yelp :p
There was a problem hiding this comment.
yeah, not sure what else we can do now we've taken hacheck internal
| ADD dockerfiles/jammy/location_types.json /nail/etc/services/ | ||
| ADD dockerfiles/jammy/location_mapping.json /nail/etc/services/ |
There was a problem hiding this comment.
is this because of context: ../.. in the docker-compose file?
There was a problem hiding this comment.
yeah - just copied how we do it elsewhere
| Section: admin | ||
| Priority: optional |
There was a problem hiding this comment.
should we just leave these out? i was a little confused as to whether this was correct since this is duplicated below (but then i realized that there's two different "sections" here)
i don't think we have anything that really cares about these being set unless they're required by the debian/compat bump - which i also don't know much about what that implies/entails
There was a problem hiding this comment.
yeah, excluding them will trigger a warning.
| Source: nerve-tools | ||
| Section: admin | ||
| Priority: optional | ||
| Maintainer: John Billings <billings@yelp.com> |
There was a problem hiding this comment.
!8ball clean this up while we're here
There was a problem hiding this comment.
can do - I was just going to leave it for the sake of a smaller diff
| def get_install_requires(): | ||
| return [ | ||
| line.strip() | ||
| for line in (HERE / 'requirements.txt').read_text().splitlines() | ||
| if line.strip() and not line.startswith('#') | ||
| ] |
There was a problem hiding this comment.
heh, we haven't really been doing the right thing with install_requires here since the beginning - but that's for later us to fix (maybe) :p
There was a problem hiding this comment.
yeah, I can break this out into a separate PR
bumps dependencies, including paasta.
Rob-Johnson
force-pushed
the
u/robj/py312-upgrade
branch
from
383fe25 to
5067b61
Compare
itests depend on internal hacheck so won't be able to run on public github runners
we didn't previously run the tests in a public environment, so never ran into this.
|
@nemacysts @ilkinmammadzada I've had to adjust the github actions setup here a little. now that hacheck is internal only, we can no longer run the itests (which run a full setup with hacheck included) - we'll have to run that in internal ci, and just run mypy + unit tests here |
3 participants
we should just vendor this into paasta-tools, but for now, I'm doing the upgrade. no pre-commit here, so no big diff - I'll come back and add that in another PR